DO NOT MERGE ME (Solutions ask ) (ABC-343) #517
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
clusty
commented
Dec 15, 2022
| m_uv1_param = AbcGeom::IV2fGeomParam(geom_params, header.getName()); // obsolete | ||
| } | ||
|
|
||
| if (AbcGeom::IV2fGeomParam::matches(header)) |
There was a problem hiding this comment.
is this 2d Vector indexed properties.
We should probably include: Vector3 and Vector4 and Un-indexed flavours.
clusty
commented
Dec 15, 2022
| @@ -0,0 +1,56 @@ | |||
| using System.Collections; | |||
There was a problem hiding this comment.
This script is a example on how to map the custom vertex attributes to Mesh UV2-3-4 (Solution Ask)
clusty
commented
Dec 15, 2022
| @@ -15,6 +17,37 @@ public class AlembicCustomData : MonoBehaviour | |||
| /// </summary> | |||
| public List<string> FaceSetNames => faceSetNames; | |||
|
|
|||
| public struct V2FAttribute | |||
There was a problem hiding this comment.
This should probably be renamed to VertexAttributes and should include a Type field.
The data should be read from c++ as a NativeArray but presented to the user as a type safe NativeArray according to the property Type.
clusty
commented
Dec 15, 2022
| @@ -2,7 +2,8 @@ | |||
| "dependencies": { | |||
| "com.unity.timeline": "1.0.0", | |||
| "com.unity.modules.unityanalytics": "1.0.0", | |||
| "com.unity.modules.cloth": "1.0.0" | |||
| "com.unity.modules.cloth": "1.0.0", | |||
| "com.unity.collections" : "1.0.0" | |||
There was a problem hiding this comment.
FixedString128 is the one that forces us to use 23.1 and "com.unity.collections"
lucillecaillaud
changed the title
mfe
changed the title
mfe
changed the title
thomas-tu
force-pushed
the
arbitrary-props
branch
from
c38e0a5 to
9199246
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arbitrary vertex attributes for meshes (polymesh and subD)